Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make title optional for navbar_page like it is in the actual function #236

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Make title optional for navbar_page like it is in the actual function #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bef3997
Make title optional for navbar_page like it is in the actual function
nstrayer Oct 23, 2023
1614e57
Commit build assets
nstrayer Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion inst/editor/build/assets/index-65b19d41.js → inst/editor/build/assets/index-11db4393.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion inst/editor/build/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
Learn how to configure a non-root public URL by running `npm run build`.
-->
<title>Shiny UI Editor</title>
<script type="module" crossorigin src="./assets/index-65b19d41.js"></script>
<script type="module" crossorigin src="./assets/index-11db4393.js"></script>
<link rel="stylesheet" href="./assets/index-22085128.css">
</head>

Expand Down
3 changes: 2 additions & 1 deletion inst/editor/src/ui-node-definitions/Bslib/page_navbar.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { nodeInfoFactory } from "../nodeInfoFactory";
import type { ShinyUiParentNode, ShinyUiNode } from "../ShinyUiNode";

export const page_navbar = nodeInfoFactory<{
title: string;
title?: string;
collapsible: boolean;
id?: string;
selected?: string;
Expand All @@ -22,6 +22,7 @@ export const page_navbar = nodeInfoFactory<{
takesChildren: true,
settingsInfo: {
title: {
optional: true,
inputType: "string",
label: "Page title",
defaultValue: "navbar-page",
Expand Down
Binary file modified inst/vscode-extension/shinyuieditor-0.5.1.vsix
View file
Open in desktop
Binary file not shown.