Delete bound output code if deleting element #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lated everytime it's neede.
… it for the goToOutput buttons
…eted and one without
…ssing around treesitter nodes directly
…er based on old server code
…igating to page and waiting for load as well
✅ Deploy Preview for shinyuieditor-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…ypes after converting back to TS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously if you deleted an output like a plot that had some render code in the server associated with it, that server code would be left in the server without and bindings. This PR adds logic to detect when deleting a node is about to create this orphaned output code and asks if the user wants to delete that code or leave it. This really helps in the situation where you start with a template that has pre-defined output code that you almost definitely don't want.