Add 315-bslib-input-switch #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
reviewed
Jul 26, 2023
inst/apps/315-bslib-input-switch/tests/testthat/test-315-bslib-input-switch.R
Outdated
Show resolved
Hide resolved
cpsievert
approved these changes
Jul 26, 2023
gadenbuie
commented
Jul 27, 2023
Comment on lines
+78
to
+90
| app$ | ||
| set_inputs(smart_punct_label = "Awesome Punctuation")$ | ||
| wait_for_js( | ||
| "document | ||
| .querySelector('label[for=\"smart_punctuation\"]') | ||
| .innerText | ||
| .includes('Awesome')" | ||
| ) | ||
|
|
||
| expect_equal( | ||
| app$get_js('document.querySelector("label[for=\\"smart_punctuation\\"]").innerText'), | ||
| "Awesome Punctuation" | ||
| ) |
There was a problem hiding this comment.
@schloerke Does this seem like the right approach? Basically, input$smart_punct_label is passed to update_switch(label = input$smart_punct_label), and I want to check that the label was actually updated.
I originally had something like
app$set_inputs(smart_punct_label = "Awesome Punctuation")
app$get_text('label[for="smart_punctuation"]')
# test the text from abovebut I saw a couple failures of this test that were likely race-condition driven where $get_text() would resolve before the label was actually updated.
schloerke
added a commit
that referenced
this pull request
Mar 14, 2024
* main: Deploy connect apps to rsc.radixu.com (#209) Generate apps deps (GitHub Actions) Approve slightly darker text input selection Add 315-bslib-input-switch (#202) Also approve sysinfo changes Add new 314 baseline Approve slightly darker text input selection; version bumps Generate apps deps (GitHub Actions) Add 314 - Unit tests for `bslib::tooltip()` (#194)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests around
bslib::input_switch()and update methodstoggle_sidebar()alias and addtoggle_switch()bslib#676