Switch from RJSONIO to jsonlite

[wch]

This fixes #572 and #228. I think we'd want jsonlite to support different behavior for digits before merging this.

I'm a bit less certain of the fromJSON() compatibility than I am of toJSON.

Some comparisons:

compare <- function(x, ...) {
  resr <- jsonlite::minify(RJSONIO::toJSON(x, ...))
  resj <- jsonlite::minify(jsonlite::toJSON(x, dataframe="columns",
            null="null", na="null", auto_unbox=TRUE, ...))

  if (!identical(resr, resj)) {
    cat(paste0("Results differ.",
      "\nRJSONIO:  ", resr,
      "\njsonlite: ", resj
    ))
  } else {
    cat(resj)
  }

  invisible()
}


compare(list(2))
# [2]

compare(data.frame(x=1:2, y=c("a","b")))
# {"x":[1,2],"y":["a","b"]}

# Differences in displaying digits
compare(
  data.frame(x=c(1.2323123231, 5.12345678901234e19), y=c("a","b"))
)
# Results differ.
# RJSONIO:  {"x":[1.2323,5.1235e+19],"y":["a","b"]}
# jsonlite: {"x":[1.2323,51234567890123399168],"y":["a","b"]}


# In RJSONIO, digits controls precision; in jsonlite, it controls digits after
# the decimal.
compare(
  data.frame(x=c(1.2323123231, 5.12345678901234e19), y=c("a","b")),
  digits = 2
)
# Results differ.
# RJSONIO:  {"x":[1.2,5.1e+19],"y":["a","b"]}
# jsonlite: {"x":[1.23,51234567890123399168],"y":["a","b"]}

# This is a RJSONIO bug
compare(list(x = matrix(nrow = 0, ncol = 1)))
#  Error: parse error: unallowed token at this point in JSON text
#                              {  "x":   }
#                      (right here) ------^

compare(list(matrix(1:2, nrow=1)))
# [[[1,2]]]

compare(list(matrix(1:2, ncol=1)))
# [[[1],[2]]]

compare(list(x = matrix(1:4, nrow=2)))
# {"x":[[1,3],[2,4]]}

# Difference in 1x1 matrix - I think jsonlite is correct
compare(list(x = matrix(1)))
# Results differ.
# RJSONIO:  {"x":[1]}
# jsonlite: {"x":[[1]]}

compare(list(x=NULL))
# {"x":null}

compare(list(as.data.frame(t(matrix(1:2, ncol=1)))))
# [{"V1":[1],"V2":[2]}]

compare(list(x=NULL))
# {"x":null}

compare(list(x=list()))
# {"x":[]}

compare(list(x=list(a=1)[0])) # Empty named list
# {"x":{}}

[wch]

Updated comparisons with jsonlite 0.9.13.99, with use_signif=TRUE. The precision issue is fixed, so i think we'll be able to merge this after the next release of jsonlite.

compare <- function(x, ...) {
  resr <- jsonlite::minify(RJSONIO::toJSON(x, ...))
  resj <- jsonlite::minify(jsonlite::toJSON(x, dataframe="columns",
            null="null", na="null", auto_unbox=TRUE, use_signif=TRUE, ...))

  if (!identical(resr, resj)) {
    cat(paste0("Results differ.",
      "\nRJSONIO:  ", resr,
      "\njsonlite: ", resj
    ))
  } else {
    cat(resj)
  }

  invisible()
}


compare(list(2))
# [2]

compare(data.frame(x=1:2, y=c("a","b")))
# {"x":[1,2],"y":["a","b"]}

compare(
  data.frame(x=c(1.2323123231, 5.12345678901234e19), y=c("a","b")),
  digits = 2
)
# {"x":[1.2,5.1e+19],"y":["a","b"]}

# This is a RJSONIO bug
compare(list(x = matrix(nrow = 0, ncol = 1)))
#  Error: parse error: unallowed token at this point in JSON text
#                              {  "x":   }
#                      (right here) ------^

compare(list(matrix(1:2, nrow=1)))
# [[[1,2]]]

compare(list(matrix(1:2, ncol=1)))
# [[[1],[2]]]

compare(list(x = matrix(1:4, nrow=2)))
# {"x":[[1,3],[2,4]]}

# Difference in 1x1 matrix - I think jsonlite is correct
compare(list(x = matrix(1)))
# Results differ.
# RJSONIO:  {"x":[1]}
# jsonlite: {"x":[[1]]}

compare(list(x=NULL))
# {"x":null}

compare(list(as.data.frame(t(matrix(1:2, ncol=1)))))
# [{"V1":[1],"V2":[2]}]

compare(list(x=NULL))
# {"x":null}

compare(list(x=list()))
# {"x":[]}

compare(list(x=list(a=1)[0])) # Empty named list
# {"x":{}}

[jeroen]

If there is anything else you need from jsonlite to merge this, please let me know.

[wch]

Thanks for asking! I think we're good, but we probably won't merge until after the next Shiny release.