-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing navtreePanel() #3326
Open
cpsievert
wants to merge
25
commits into
main
Choose a base branch
from
navtreePanel
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto 'empty' nav/tab
…e is precedence in navbarPage() and mention them in the warning
Note to self: all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
navtreePanel()
-- a modern drop-in replacement fornavlistPanel()
which offers two main benefits:navbarMenu()
s via collapsing submenus (you're only allowed one innavlistPanel()
,tabsetPanel()
, etc)For a basic example:
navtreePanel()
works with all the tab updating functions, here's a small demo:Testing notes
Install
remotes::install_github("rstudio/shiny")
and run the app above. You should see a collapsed menu appear after clicking "Add"First, click the "Add" button and a collapsed menu should appear. Then, click "select" and that collapsed menu should expand and the item named "Dynamic" tab should be highlighted. Then, click "Remove" and the menu should disappear.
TODO