Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use base64 encoded secrets in test to avoid base64 errors with new libssl #1131

Merged
merged 1 commit into from
Jan 22, 2025
Merged

use base64 encoded secrets in test to avoid base64 errors with new libssl #1131

merged 1 commit into from
Jan 22, 2025

Conversation

aronatkins
Copy link
Contributor

Simple strings cannot be used as base64 encoded input. Encode values used downstream to construct auth headers.

openssl::base64_decode("bar")
#> raw(0)
openssl::base64_decode("123")
#> raw(0)

fixes #1130

@aronatkins aronatkins requested a review from toph-allen January 21, 2025 21:18
@aronatkins aronatkins merged commit e43e273 into main Jan 22, 2025
11 checks passed
@aronatkins aronatkins deleted the aron-issue-1130 branch January 22, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toph-allen toph-allen toph-allen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CRAN: address test failures
2 participants
@aronatkins @toph-allen