Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return stub deployments when matching records do not exist. #1015

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

aronatkins
Copy link
Contributor

The stub deployment is subsequently used to look-up the application by name. This lets showLogs, configureApp, setProperty, and unsetProperty interact with shinyapps.io when the client lacks a deployment record.

Does not address issues with publishing, such as #1013.

Fixes #985
Fixes #989

The stub deployment is subsequently used to look-up the application by name.
This lets showLogs, configureApp, setProperty, and unsetProperty interact with
shinyapps.io when the client lacks a deployment record.

Does not address issues with publishing, such as #1013.

Fixes #985
Fixes #989
Copy link
Contributor

@toph-allen toph-allen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking my understanding: This works because the ShinyApps.io API works with just the info contained in the stub deployment.

@aronatkins
Copy link
Contributor Author

Checking my understanding: This works because the ShinyApps.io API works with just the info contained in the stub deployment.

The getAppByName function only needs the server, account, and name to locate an application. That's enough to let these calls interact with shinyapps.io -- a full deployment record is unnecessary.

We likely need something similar for the re-deploy workflow, but that will probably need to create a full deployment record. The functions referenced in this PR were the only ones which used findDeployment(), which let me create a narrower solution.

@aronatkins aronatkins merged commit 55a7ea3 into main Oct 11, 2023
10 checks passed
@aronatkins aronatkins deleted the aron-deployments-find branch October 11, 2023 14:56
@toph-allen
Copy link
Contributor

Verification

Deployed a test app to ShinyApps.io and deleted the rsconnect subdirectory containing deployment records.

  • On the previous version of rsconnect I'd see an error when running rsconnect::showProperties().
  • On the version installed from GitHub containing this fix, I'm prompted to pick an account, and when I pick my ShinyApps.io account, I see the app's properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants