Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for supplying image via environment variable #1063

Closed
michaelmayer2 opened this issue Apr 24, 2024 · 0 comments · Fixed by #1065
Closed

Support for supplying image via environment variable #1063

michaelmayer2 opened this issue Apr 24, 2024 · 0 comments · Fixed by #1065
Assignees
@aronatkins

Comments

@michaelmayer2
Copy link

rsconnect since version 0.8.26 supports specifying an image for the deployed content which is really great.

It would be very helpful if rsconnect could not only explicitly use the image argument in the rsconnect() function call but also pick it up from an environment variable.

The use case is that on a given environment a default image can be defined and - unless the user overwrites it by specifying the image in the rsconnect() call will use this one for publishing.
@michaelmayer2 michaelmayer2 changed the title Support for supplying image name via environment variable Support for supplying image via environment variable Apr 24, 2024
@aronatkins aronatkins self-assigned this Apr 24, 2024
aronatkins added a commit that referenced this issue Apr 24, 2024
@aronatkins
default image from RSCONNECT_IMAGE
c5747e2 
fixes #1063
aronatkins added a commit that referenced this issue Apr 24, 2024
@aronatkins
default image from RSCONNECT_IMAGE
25d6c4c 
fixes #1063
@aronatkins aronatkins mentioned this issue Apr 24, 2024
Merged
aronatkins added a commit that referenced this issue Apr 24, 2024
@aronatkins
default image from RSCONNECT_IMAGE
f58b584 
fixes #1063
aronatkins added a commit that referenced this issue Apr 24, 2024
@aronatkins
default image from RSCONNECT_IMAGE (#1065)
53d1591 
* default image from RSCONNECT_IMAGE

fixes #1063

* test precedence between image and RSCONNECT_IMAGE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aronatkins aronatkins

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

default image from RSCONNECT_IMAGE rstudio/rsconnect
2 participants
@aronatkins @michaelmayer2