serialize multi-value metadata entries as comma-separated values

fixes #1017

NEWS.md

@@ -7,6 +7,9 @@
 * `rpubsUpload()` correctly records the initial RPubs destination, allowing
   republishing.
 
+* `deployApp()` and friends record multi-value `metadata` entries as
+  comma-separated values. (#1017)
+
 # rsconnect 1.1.1
 
 * Added `space` parameter to deploy directly to a space in Posit Cloud.

R/deployApp.R

@@ -112,6 +112,9 @@
 #' @param metadata Additional metadata fields to save with the deployment
 #'   record. These fields will be returned on subsequent calls to
 #'   [deployments()].
+#'
+#'   Multi-value fields are recorded as comma-separated values and returned in
+#'   that form. Custom value serialization is the responsibility of the caller.
 #' @param forceUpdate What should happen if there's no deployment record for
 #'   the app, but there's an app with the same name on the server? If `TRUE`,
 #'   will always update the previously-deployed app. If `FALSE`, will ask

R/deployments.R

@@ -145,6 +145,9 @@ deploymentRecord <- function(name,
     url = url %||% "",
     version = version
   )
+  # convert any multi-value metadata entries into comma-separated values
+  # this prevents write.dcf from writing multiple records into one file.
+  metadata <- lapply(metadata, function(v) paste0(v, collapse = ", "))
   c(standard, metadata)
 }
 

tests/testthat/test-deployments.R

@@ -69,6 +69,15 @@ test_that("can read/write metadata", {
   expect_equal(out$meta2, "two")
 })
 
+test_that("can read/write metadata having multiple values", {
+  dir <- local_temp_app()
+
+  addTestDeployment(dir, metadata = list(engines = c("knitr","markdown")))
+  out <- deployments(dir, excludeOrphaned = FALSE)
+  expect_equal(nrow(out), 1)
+  expect_equal(out$engines, "knitr, markdown")
+})
+
 test_that("can read/write version", {
   dir <- local_temp_app()