Discover site generators in index.Rmd files in parent directories #1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note this requires the site generator to add a `subdirs = TRUE` field to opt-in to this behavior
|
Have you managed to test this out w/ blogdown yet? |
|
@jjallaire I just tested this with the default lithium theme. I was able to successfully knit to HTML a |
|
Hmm...this should require an update to blogdown (addition of |
|
@jjallaire Yes, I need a little more work on blogdown's side. @apreshill I'll let you know when both blogdown and rmarkdown are ready for testing. Thanks! |
|
Note that this definitely doesn't work as currently checked in (working on testing/tweaking it now) |
|
Okay, I've now pushed the changes and tested that if a site generator adds |
yihui
approved these changes
Sep 18, 2020
yihui
added a commit
to rstudio/blogdown
that referenced
this pull request
Sep 18, 2020
thanks to rstudio/rmarkdown#1898, the Knit button in RStudio will work for blogdown posts (finally!)
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
Sep 24, 2020
* rstudio_origin/master: fix rstudio#1905: a chunk with the class "fold-hide" should only hide itself (rstudio#1906) bump version after merging rstudio#1899 lua filter -> Lua filter Add an argument `lua_filters` to pandoc_options() to store them in the output format object (rstudio#1899) recursve into the parent dir at the end also suppor dir input in proj_root() list.files() with full.names = TRUE (so the files could be read with corret paths), and pass down the `file`/`pattern` arguments in the recursion use our own proj_root() instead of introducing a dependency rename package_root() to proj_root() generalize the package_root() function to work with more types of projects Discover site generators in index.Rmd files in parent directories (rstudio#1898) only install pkgdown for website build (rstudio#1900) Generalize number sections (rstudio#1879) enable figure cropping in pdf_document() only when both pdfcrop and ghostscript are found (yihui/knitr#954), and do not limit this feature to non-Windows platforms add the citation entry for the R Markdown Cookbook add lua filter vignette to pkgdown website (rstudio#1894) close rstudio#1889: evaluate the output argument before changing working directory in pandoc_convert() (rstudio#1890)
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
Sep 24, 2020
Merge remote-tracking branch 'rstudio_origin/master' into css-slash-fix # By Yihui Xie (12) and others # Via GitHub * rstudio_origin/master: (22 commits) fix rstudio#1905: a chunk with the class "fold-hide" should only hide itself (rstudio#1906) bump version after merging rstudio#1899 lua filter -> Lua filter Add an argument `lua_filters` to pandoc_options() to store them in the output format object (rstudio#1899) recursve into the parent dir at the end also suppor dir input in proj_root() list.files() with full.names = TRUE (so the files could be read with corret paths), and pass down the `file`/`pattern` arguments in the recursion use our own proj_root() instead of introducing a dependency rename package_root() to proj_root() generalize the package_root() function to work with more types of projects Discover site generators in index.Rmd files in parent directories (rstudio#1898) only install pkgdown for website build (rstudio#1900) Generalize number sections (rstudio#1879) enable figure cropping in pdf_document() only when both pdfcrop and ghostscript are found (yihui/knitr#954), and do not limit this feature to non-Windows platforms add the citation entry for the R Markdown Cookbook add lua filter vignette to pkgdown website (rstudio#1894) close rstudio#1889: evaluate the output argument before changing working directory in pandoc_convert() (rstudio#1890) tweak news require Pandoc >= 1.14 xfun 0.16 is on CRAN now ... # Conflicts: # NEWS.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note this requires the site generator to add a
subdirs = TRUEfield to opt-in to this behaviorAlso note this code is speculative (has not been tested at all) so you'll want to try it out before merging :-)
This should in principle allow the IDE to call
render_site()for Rmds below the root site directory.