Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconsider warning for croptools for default value #2077

Closed
cderv opened this issue Mar 22, 2021 · 2 comments
Closed

Reconsider warning for croptools for default value #2077

cderv opened this issue Mar 22, 2021 · 2 comments
Labels
feature a feature request or enhancement next to consider for next release
Milestone
v2.8

Comments

@cderv
Copy link
Collaborator

cderv commented Mar 22, 2021

Following discussion in #2016 we should try modifying following #2016 (comment) idea

This should avoid having users seeing warning in CI for example or just warning they did not expect because they don't even know without cropping.
@cderv cderv added feature a feature request or enhancement and removed enhancement labels Apr 14, 2021
@yihui yihui added the next to consider for next release label Apr 26, 2021
@yihui yihui mentioned this issue Apr 26, 2021
Closed
yihui added a commit that referenced this issue May 6, 2021
@yihui
support fig_crop = "auto" in pdf formats (#2077)
429d29c
@yihui yihui closed this as completed in 84ff469 May 6, 2021
@yihui
Copy link
Member

yihui commented May 6, 2021 •
edited
Loading

I just made the change, and will see if this would introduce breaking changes in revdep checks. (Update: I didn't see breaking changes, so this has been included in the CRAN release v2.8)

@cderv cderv added this to the v2.8 milestone May 10, 2021
@github-actions
Copy link

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue by following the issue guide (https://yihui.org/issue/), and link to this old issue if necessary.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature a feature request or enhancement next to consider for next release
Projects
None yet
Milestone
v2.8
Development

No branches or pull requests
2 participants
@yihui @cderv