Skip to content

Commit

Permalink
fix #1716: drop the compact-title option in YAML; the smaller spaci…
Browse files Browse the repository at this point in the history
…ng does not seem to worth our official support, and we will let users opt-in if they really prefers the spacing, at the price of providing their own LaTeX templates if they have multiple authors in a document
  • Loading branch information
yihui committed Dec 3, 2019
1 parent f6961af commit cf8e5df
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 22 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: rmarkdown
Type: Package
Title: Dynamic Documents for R
Version: 1.18.2
Version: 1.18.3
Authors@R: c(
person("JJ", "Allaire", role = "aut", email = "[email protected]"),
person("Yihui", "Xie", role = c("aut", "cre"), email = "[email protected]", comment = c(ORCID = "0000-0003-0645-5666")),
Expand Down
2 changes: 2 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
rmarkdown 1.19
================================================================================

- For the output format `pdf_document()`, we no longer adjust the vertical spacing of the title area. This means there will be a larger spacing above the document title in PDF. If you prefers the old (smaller) spacing, please download https://github.com/rstudio/rmarkdown/blob/f6961af/inst/rmd/latex/compact-title.tex and include it to the preamble via the `includes` option of `pdf_document`. However, please note that this means you won't be able to have multiple authors in the `author` field of the YAML frontmatter, unless you use a custom LaTeX template. With the default LaTeX template, you will run into the error in #1716. Besides, the `compact-title` option in YAML is no longer supported.

- The `encoding` argument is no longer passed to the `intermediates_generator` of R Markdown output formats. The `intermediates_generator` function can only accept arguments `input_file` and `intermediates_dir` now (see `?rmarkdown::output_format`). This is a breaking change to developers. If you are an output format developer, you have to remove the `encoding` argument in your `intermediates_generator` if your output format uses this function.

- The `encoding` argument is no longer passed to the `render` element of the site generator (see `?rmarkdown::render_site`).
Expand Down
5 changes: 0 additions & 5 deletions R/pdf_document.R
Original file line number Diff line number Diff line change
Expand Up @@ -172,11 +172,6 @@ pdf_document <- function(toc = FALSE,
# set the margin to 1 inch if no geometry options or document class specified
if (!any(c("geometry", "documentclass") %in% names(metadata)))
args <- c(args, "--variable", "geometry:margin=1in")

# use titling package to change title format to be more compact by default
if (!xfun::isFALSE(metadata[["compact-title"]])) args <- c(
args, append_in_header(file = pkg_file("rmd/latex/compact-title.tex"))
)
}

if (length(extra_dependencies) || has_latex_dependencies(knit_meta)) {
Expand Down
16 changes: 0 additions & 16 deletions inst/rmd/latex/compact-title.tex

This file was deleted.

0 comments on commit cf8e5df

Please sign in to comment.