Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't snapshot() development dependencies #1399

Merged
merged 5 commits into from
Jun 7, 2023
Merged

Conversation

hadley
Copy link
Member

@hadley hadley commented Jun 7, 2023

Fixes #1019

@hadley hadley requested a review from kevinushey June 7, 2023 17:06
R/install.R Outdated Show resolved Hide resolved
R/snapshot.R Outdated Show resolved Hide resolved
R/snapshot.R Outdated Show resolved Hide resolved
@@ -143,7 +143,7 @@ install <- function(packages = NULL,
return(renv_pak_install(packages, libpaths, project))
}

packages <- packages %||% renv_snapshot_dependencies(project, "implicit")
packages <- packages %||% renv_snapshot_dependencies(project, dev = TRUE)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to document the fact that install() now respects the snapshot type? (The change probably makes sense)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yeah, good catch.

@hadley hadley merged commit 1d7da5d into main Jun 7, 2023
@hadley hadley deleted the dont-snapshot-suggested branch June 7, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggests dependencies included by default
2 participants