Simplify handling of Suggested dependencies
#1394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* So a top-level `DESCRIPTION` is treated the same way regardless of whether it's a "Package" description or not. * Document how "development dependencies" are found in `dependencies()` * Impute a roxygen2/devtools dependency if the package has a `RoxygenNote` field
hadley
commented
Jun 5, 2023
hadley
commented
Jun 5, 2023
kevinushey
approved these changes
Jun 5, 2023
|
To get the tests to pass, I kept pulling the string and it kept getting longer and longer. I think I see a simpler/cleaner approach so no need to review until I've tried that. |
hadley
commented
Jun 6, 2023
| @@ -195,14 +210,6 @@ test_that("Suggest dependencies are ignored by default", { | |||
| expect_false(renv_package_installed("egg")) | |||
| }) | |||
|
|
|||
| test_that("Suggest dependencies are used when requested", { | |||
There was a problem hiding this comment.
Moved to install.R which is a better location.
|
@kevinushey It's worth taking another look at this now, since I've also slightly changed the meaning of |
kevinushey
reviewed
Jun 6, 2023
| renv_dependencies_list( | ||
| path, | ||
| extract_chr(matches, 2L), | ||
| extract_chr(matches, 3L), | ||
| extract_chr(matches, 4L), | ||
| dev | ||
| dev = field == "Suggests" |
There was a problem hiding this comment.
FWIW I think the reason I had this was to avoid issues with DESCRIPTION files located in sub-directories within a project, but that imply separate considerations (e.g. should we really be parsing those for dependencies at all from the top-level?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTIONis now treated the same way regardless of whether it's a "Package" or not.settings$package.dependency.fields()no longer affects transitive dependencies.dependencies()