Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix rows_complete() dropping non-tested columns #591

Merged
merged 6 commits into from
Jan 27, 2025

Conversation

yjunechoe
Copy link
Collaborator

@yjunechoe yjunechoe commented Jan 26, 2025

Summary

Similar to #588 - ensures that rows_complete() preserves all columns instead of just the ones tested.

Now:

create_agent(small_table) %>% 
  rows_complete(c(a, b, c)) %>% 
  interrogate() %>% 
  get_data_extracts(1)
#> 
#> ── Interrogation Started - there is a single validation step ───────────────────────────────────────────
#> ✔ Step 1: OK.
#> 
#> ── Interrogation Completed ─────────────────────────────────────────────────────────────────────────────
#> # A tibble: 2 × 8
#>   date_time           date           a b             c     d e     f    
#>   <dttm>              <date>     <int> <chr>     <dbl> <dbl> <lgl> <chr>
#> 1 2016-01-06 17:23:00 2016-01-06     2 5-jdo-903    NA 3892. FALSE mid  
#> 2 2016-01-30 11:23:00 2016-01-30     1 3-dka-303    NA 2230. TRUE  high

Previously:

create_agent(small_table) %>% 
  rows_complete(c(a, b, c)) %>% 
  interrogate() %>% 
  get_data_extracts(1)
#> 
#> ── Interrogation Started - there is a single validation step ───────────────────────────────────────────
#> ✔ Step 1: OK.
#> 
#> ── Interrogation Completed ─────────────────────────────────────────────────────────────────────────────
#> # A tibble: 2 × 3
#>       a b             c
#>   <int> <chr>     <dbl>
#> 1     2 5-jdo-903    NA
#> 2     1 3-dka-303    NA

Rider: fixes a critical typo from #588 where I got the T/F flipped in tbl_rows_distinct_2() (interrogate_distinct() method for mysql and bigquery)

Related GitHub Issues and PRs

Checklist

@yjunechoe yjunechoe marked this pull request as ready for review January 26, 2025 17:59
Copy link
Member

@rich-iannone rich-iannone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@rich-iannone
Copy link
Member

@yjunechoe this is great, thanks! You can merge whenever you like!

@yjunechoe yjunechoe merged commit 7a2b621 into rstudio:main Jan 27, 2025
12 checks passed
@yjunechoe yjunechoe deleted the rows_complete-extracts branch January 27, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants