Preserve classes when reading from validation_set$values

[yjunechoe]

Summary

This PR preserves the class of value where possible. Two consequences:

1. When value and column are not of the same class (and thus their interaction is not well defined), the associated warning/error now gets to be produced at interrogate(), which shows up at interrogate/report. Using a modified reprex from Evaluation of datetimes not as expected  #536:

# NOTE: {lubridate} not loaded for this chunk
devtools::load_all()

df <- data.frame(
  date = Sys.Date() + 1,
  datetime = Sys.time() + 1
)

agent_base_loaded <- create_agent(df) |> 
  col_vals_lte(datetime, Sys.Date()) |> 
  col_vals_lte(date, Sys.Date()) |>
  interrogate(show_step_label = TRUE)
#> 
#> ── Interrogation Started - there are 2 steps ──────────────────────────────────
#> ℹ Step 1: an evaluation issue requires attention (WARNING).
#> ✔ Step 2: OK.
#> 
#> ── Interrogation Completed ────────────────────────────────────────────────────

agent_base_loaded$validation_set$capture_stack[[1]]$warning
#> <warning/rlang_warning>
#> Warning:
#> There was 1 warning in `dplyr::mutate()`.
#> ℹ In argument: `pb_is_good_ = datetime <= structure(19887, class = "Date")`.
#> Caused by warning:
#> ! Incompatible methods ("Ops.POSIXt", "Ops.Date") for "<="

2. When methods are defined for the class, they get used by pointblank at interrogate(). So if we define the same agent after {lubridate} has been loaded, we get the more sensible behavior for comparing datetime to date:

library(lubridate)

# Loading lubridate puts the custom method `<=.POSIXt` on the search path,
# which overrides the problematic `Ops.POSIXt` method from base
sloop::s3_dispatch(df$datetime <= Sys.Date())
#>    <=.POSIXct
#> => <=.POSIXt
#>    <=.default
#>    Ops.POSIXct
#> -> Ops.POSIXt
#>    Ops.default
#> -> <= (internal)

# This is picked up on evaluation - datetime can now be compared with date without warning
agent_lubridate_loaded <- create_agent(df) |> 
  col_vals_lte(datetime, Sys.Date()) |> 
  col_vals_lte(date, Sys.Date()) |>
  interrogate(show_step_label = TRUE)
#> 
#> ── Interrogation Started - there are 2 steps ──────────────────────────────────
#> ✔ Step 1: OK.
#> ✔ Step 2: OK.
#> 
#> ── Interrogation Completed ────────────────────────────────────────────────────

Implementational details

This PR ensures that reading from validation_set$values in the internal function get_values_at_idx() preserves class of the values. This is done by simply replacing unlist(recursive = FALSE) with subsetting [[1]] to this avoids the attribute-stripping behavior of unlist():

unlist(list(Sys.Date()), recursive = FALSE)
#> [1] 19887

Relatedly, the PR also includes a small surgery on interrogate_set() to avoid set operation functions since those strip attributes as well. These have been refactored to use subsetting (x[x %in% y], etc.).

intersect(Sys.Date() + 1:2, Sys.Date() + 2:3)
#> [1] 19889

Related GitHub Issues and PRs

• Ref: Evaluation of datetimes not as expected  #536, value is stripped of its class in comparison validation functions #537

Checklist

• I understand and agree to the Code of Conduct.
• I have listed any major changes in the NEWS.
• I have added testthat unit tests to tests/testthat for any new functionality.

[rich-iannone]

LGTM!

[rich-iannone]

This is great! Feel free to merge anytime :)