Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ellipsis checking #770

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Move ellipsis checking #770

merged 2 commits into from
Aug 29, 2023

Conversation

juliasilge
Copy link
Member

Closes #760

This PR moves the ellipsis checking to after the early return when we don't write. The messaging now looks like this:

library(pins)
b <- board_connect()
#> Connecting to Posit Connect 2023.07.0 at <https://colorado.posit.co/rsc>

b |> pin_write(
  1:10, 
  "julia.silge/some-amazing-numbers",
  access_type = "all"
)
#> Guessing `type = 'rds'`
#> ! The hash of pin "julia.silge/some-amazing-numbers" has not changed.
#> • Your pin will not be stored.

Created on 2023-08-28 with reprex v2.0.2

@juliasilge juliasilge merged commit 8e50139 into main Aug 29, 2023
@juliasilge juliasilge deleted the move-ellipsis-checking branch August 29, 2023 00:13
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pin_write() cannot set access_type on an update for Connect
1 participant