Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Drive board #749

Merged
merged 12 commits into from
Jun 20, 2023
Merged

Add Google Drive board #749

merged 12 commits into from
Jun 20, 2023

Conversation

juliasilge
Copy link
Member

Closes #728

Wow, using Google Drive for this is not speedy 😳

@juliasilge
Copy link
Member Author

juliasilge commented Jun 14, 2023

We should definitely not run the tests for board_gdrive() in CI; they take basically INFINITY amount of time. We also run the tests for board_ms365() only locally, and the use of Microsoft OneDrive is equivalent in many ways to Google Drive here.

@juliasilge juliasilge changed the title Start work on Google Drive board Add Google Drive board Jun 14, 2023
@juliasilge juliasilge marked this pull request as ready for review June 14, 2023 18:14
Copy link
Member

@hadley hadley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any hope of speeding it up by caching drive ids somewhere?

@juliasilge
Copy link
Member Author

juliasilge commented Jun 20, 2023

Any hope of speeding it up by caching drive ids somewhere?

I don't believe so. There's no "extra" mapping between drive ID and something else that we can cache somewhere (like the Connect mappings from GUID to content name).

Just for clarity here, the normal pins caching mechanism does work as expected here, so you don't re-download pin content if it hasn't changed. However, even the process of looking up the pin metadata to check this feels sluggish.

@juliasilge juliasilge merged commit 0da1181 into main Jun 20, 2023
@juliasilge juliasilge deleted the google-drive-board branch June 20, 2023 21:19
@github-actions
Copy link

github-actions bot commented Jul 5, 2023

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider board based on googledrive R package
2 participants