Spring cleaning 🧼 #731
Merged
Spring cleaning 🧼 #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #682 |
DavisVaughan
reviewed
Mar 9, 2023
| abort("`name` must not contain slashes", class = "pins_check_name") | ||
| cli_abort( | ||
| "{.var name} must not contain slashes", | ||
| class = "pins_check_name", |
There was a problem hiding this comment.
Very minor - We have somewhat gotten in the habit of classing our errors with
{pkg}_{error}_{descriptor}
# like
pins_error_invalid_name
in practice it doesn't matter much, just letting you know
There was a problem hiding this comment.
Thanks! This particular one has been around for a while (it predates my work on pins) so I probably won't change it but I'll keep in mind moving forward. 👍
Co-authored-by: Davis Vaughan <[email protected]>
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #730