simplify url-patching for manifest #686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliasilge
added a commit
that referenced
this pull request
Dec 16, 2022
* Stash work on versioned board_url * Get started on `board_url()` changes after manifest work * Fix `pin_meta` method * Update test to accommodate `is_testing()` * Update `pin_meta` to check for versioning * Update NEWS * Get rid of "No encoding supplied: defaulting to UTF-8." * Rename to `end_with_slash()` * Pass through other board args correctly * Update R/board_url.R Co-authored-by: Hadley Wickham <[email protected]> * Feedback from code review * Test error messages better * Update test for new error message * simplify url-patching for manifest (#686) * Add example for manifest file * Update from master to main * Update R/board_url.R Co-authored-by: Hadley Wickham <[email protected]> * Update R/board_url.R Co-authored-by: Hadley Wickham <[email protected]> * Fix up error message handling * Remember that paste0 is already vectorized * Remove unnecessary `which()` Co-authored-by: Hadley Wickham <[email protected]> Co-authored-by: Ian Lyttle <[email protected]>
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @juliasilge - hopefully this can be useful.
I found a much simpler way to form the URLs, to the point where I was wondering what I was thinking in the first place 😳