-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused/broken UI and addin functionality #679
Conversation
This will let us move forward with #678 more easily. |
viewer$connectionClosed(type = "Pins", host = board$name) | ||
.globals$ui_connections[[board$name]] <- FALSE | ||
} | ||
lifecycle::deprecate_stop("1.1.0", "pin_preview()") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I deprecated this because I think it is still somewhat usable in the current release, but it has been @keywords internal
and documented as "no longer used" for over a year so we probably could remove it altogether. Again, this is not something that would typically be used in production or scheduled jobs.
As far as I can tell from my interactive work and the automated tests, functionality like read/write/list/etc for the legacy API all are unaffected by these changes. |
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
This PR removes/deprecates functions for viewing legacy API pins in the RStudio Viewer pane. Some of these didn't work anymore:
Created on 2022-11-18 with reprex v2.0.2
Created on 2022-11-18 with reprex v2.0.2
Some of this may still work but would not be a part of typical production or scheduled jobs because these are intended for interactive use only.