Use an R option or env variable to turn on/off Connect content cache #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR also does some code styling on |
juliasilge
commented
Oct 21, 2022
R/board_rsconnect.R
Outdated
Comment on lines
561
to
565
| if (use_cache()) { | ||
| cache <- read_cache(path) | ||
| cache[[key]] <- value | ||
| write_yaml(cache, path) | ||
| } |
There was a problem hiding this comment.
I am checking the cache option in both read_cache() and update_cache() even though the second calls the first so we avoid writing to the cache here
juliasilge
commented
Oct 21, 2022
juliasilge
changed the title
juliasilge
commented
Oct 25, 2022
Merge commit '4439a8f174f245305045b5da6f0ee7a5bce0472a' #Conflicts: # .github/workflows/R-CMD-check.yaml
|
Closed by #667 |
|
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #635