add ... to s3_upload_yaml to fix issue noted in #625

[fh-mthomson]

Fixes issue discussed in #625 (comment)

[juliasilge]

Thank you so much for this @fh-mthomson! 🙌

Can I make sure I am understanding this super clearly? This change will make it so both the main file (such as .rds or .csv) and the data.txt are uploaded with the same arguments/options for S3 PutObject? That seems like the right behavior to me, and it's hard to imagine a situation where that isn't what folks want.

[fh-mthomson]

Exactly! Since the bucket to which I'm writing has SSE enabled, trying to write the data.txt file resulted in permissions errors when trying to call put_object() but without the ServerSideEncryption specification available.

So, I think it's reasonable to expect that S3-level options should be passed through to all instances of put_object() since each call is inherently within the same bucket/prefix.

[juliasilge]

That makes sense! Thank you so much 🙏

[github-actions]

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.