-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass the dots from pin_write()
through to s3_upload_file()
#648
Conversation
Also closes #625 |
@@ -209,14 +215,15 @@ pin_fetch.pins_board_s3 <- function(board, name, version = NULL, ...) { | |||
|
|||
#' @export | |||
pin_store.pins_board_s3 <- function(board, name, paths, metadata, | |||
versioned = NULL, ...) { | |||
versioned = NULL, x = NULL, ...) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The function signature here needed to be made the same as other pin_store
methods.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This behavior LGTM! I didn't try it locally (but am happy to if useful!)
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Closes #628
Created on 2022-08-31 with reprex v2.0.2