-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arrow to Suggests? #644
Comments
Related to #537 where we discussed this before |
The But really my issue with it is that it's a complicated installation that I don't use. I'm trying to reduce the warm up time on this lambda, and every little thing that I can cut out of the image could potentially help with that. |
Let's do this 👍 Do you want to contribute a PR @jonthegeek? We would want to make a little pair of helper functions that work just like |
I'll look into it soon (if nobody beats me to it), @juliasilge. I haven't dug into the pins code yet so I'm not sure how confused I'll get when I do 🙃 |
Oh, this is way more straightforward than I thought, PR coming soon! |
Closes rstudio#644. Note: writing to arrow was previously returning the object (invisibly), rather than the fully qualified path (invisibly) like the help says. It now returns the path. As far as I can tell, no tests check this. I think json and csv likely return the object, but I haven't dug in to confirm.
* Move arrow to suggests. Closes #644. Note: writing to arrow was previously returning the object (invisibly), rather than the fully qualified path (invisibly) like the help says. It now returns the path. As far as I can tell, no tests check this. I think json and csv likely return the object, but I haven't dug in to confirm. * Skip arrow test * Update NEWS Co-authored-by: Julia Silge <[email protected]>
This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
If you're reading and writing json or rds,
{arrow}
can be a relatively heavy, unused dependency. Would it be possible to move it to suggests? I'm not sure how tricky that might be (for example, to anticipate what types might need to be read), so I understand if this isn't feasible. I'm just seeing what I can cut out to make my containers a little smaller!The text was updated successfully, but these errors were encountered: