Skip to content

Commit

Permalink
Change to board_connect() and other rebranding changes (#689)
Browse files Browse the repository at this point in the history
* Initial go, which does not work

* Update many things to Posit Connect

* Update NEWS

* Update docs, redocument

* Let's rename this one simple `rsc_*()` function

* One more snapshot

* Update snapshot

* Pass all args directly through to old function, no deprecated args in new function

* Fix arg passing to legacy board
  • Loading branch information
juliasilge authored Dec 16, 2022
1 parent c26497d commit cf70d5c
Show file tree
Hide file tree
Showing 36 changed files with 260 additions and 203 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
pull_request:
branches: [main, master]

name: rstudio-connect
name: posit-connect

jobs:
rstudio-connect:
Expand All @@ -18,10 +18,10 @@ jobs:
- uses: actions/checkout@v2

# TODO: should use a real action to make sure that cleanup happens on error...
- name: run RStudio Connect
- name: run Posit Connect
run: |
docker run -d -v $PWD/.github/users.txt:/etc/users.txt -v $PWD/.github/rstudio-connect.gcfg:/etc/rstudio-connect/rstudio-connect.gcfg --name=pins-connect -p 3939:3939 --privileged -e RSC_LICENSE -e RSTUDIO_CONNECT_HASTE=enabled rstudio/rstudio-connect:${RSC_VERSION}
- name: create RStudio Connect users
- name: create Posit Connect users
run: |
docker exec pins-connect awk ' { system("useradd -m -s /bin/bash "$1); system("echo \""$1":"$2"\" | chpasswd"); system("id "$1) } ' /etc/users.txt
Expand Down Expand Up @@ -67,7 +67,7 @@ jobs:
run: |
docker logs pins-connect
- name: clean up RStudio Connect
- name: clean up Posit Connect
if: always()
run: |
docker stop pins-connect
Expand Down
35 changes: 18 additions & 17 deletions NAMESPACE
Original file line number Diff line number Diff line change
@@ -1,126 +1,126 @@
# Generated by roxygen2: do not edit by hand

S3method(board_browse,pins_board)
S3method(board_browse,pins_board_connect)
S3method(board_browse,pins_board_datatxt)
S3method(board_browse,pins_board_github)
S3method(board_browse,pins_board_kaggle)
S3method(board_browse,pins_board_local)
S3method(board_browse,pins_board_rsconnect)
S3method(board_deparse,pins_board)
S3method(board_deparse,pins_board_azure)
S3method(board_deparse,pins_board_connect)
S3method(board_deparse,pins_board_folder)
S3method(board_deparse,pins_board_kaggle_competition)
S3method(board_deparse,pins_board_kaggle_dataset)
S3method(board_deparse,pins_board_rsconnect)
S3method(board_deparse,pins_board_s3)
S3method(board_desc,default)
S3method(board_desc,pins_board_folder)
S3method(board_pin_create,pins_board)
S3method(board_pin_create,pins_board_connect)
S3method(board_pin_create,pins_board_datatxt)
S3method(board_pin_create,pins_board_github)
S3method(board_pin_create,pins_board_kaggle)
S3method(board_pin_create,pins_board_local)
S3method(board_pin_create,pins_board_rsconnect)
S3method(board_pin_find,pins_board)
S3method(board_pin_find,pins_board_connect)
S3method(board_pin_find,pins_board_datatxt)
S3method(board_pin_find,pins_board_github)
S3method(board_pin_find,pins_board_kaggle)
S3method(board_pin_find,pins_board_local)
S3method(board_pin_find,pins_board_packages)
S3method(board_pin_find,pins_board_rsconnect)
S3method(board_pin_get,pins_board)
S3method(board_pin_get,pins_board_connect)
S3method(board_pin_get,pins_board_datatxt)
S3method(board_pin_get,pins_board_github)
S3method(board_pin_get,pins_board_kaggle)
S3method(board_pin_get,pins_board_local)
S3method(board_pin_get,pins_board_packages)
S3method(board_pin_get,pins_board_rsconnect)
S3method(board_pin_remove,pins_board)
S3method(board_pin_remove,pins_board_connect)
S3method(board_pin_remove,pins_board_datatxt)
S3method(board_pin_remove,pins_board_github)
S3method(board_pin_remove,pins_board_kaggle)
S3method(board_pin_remove,pins_board_local)
S3method(board_pin_remove,pins_board_rsconnect)
S3method(board_pin_versions,default)
S3method(board_pin_versions,pins_board_connect)
S3method(board_pin_versions,pins_board_datatxt)
S3method(board_pin_versions,pins_board_github)
S3method(board_pin_versions,pins_board_kaggle)
S3method(board_pin_versions,pins_board_local)
S3method(board_pin_versions,pins_board_rsconnect)
S3method(pin,AsIs)
S3method(pin,character)
S3method(pin,data.frame)
S3method(pin,default)
S3method(pin_delete,pins_board_azure)
S3method(pin_delete,pins_board_connect)
S3method(pin_delete,pins_board_folder)
S3method(pin_delete,pins_board_kaggle_competition)
S3method(pin_delete,pins_board_kaggle_dataset)
S3method(pin_delete,pins_board_ms365)
S3method(pin_delete,pins_board_rsconnect)
S3method(pin_delete,pins_board_s3)
S3method(pin_delete,pins_board_url)
S3method(pin_exists,pins_board_azure)
S3method(pin_exists,pins_board_connect)
S3method(pin_exists,pins_board_folder)
S3method(pin_exists,pins_board_kaggle_competition)
S3method(pin_exists,pins_board_kaggle_dataset)
S3method(pin_exists,pins_board_ms365)
S3method(pin_exists,pins_board_rsconnect)
S3method(pin_exists,pins_board_s3)
S3method(pin_exists,pins_board_url)
S3method(pin_fetch,pins_board_azure)
S3method(pin_fetch,pins_board_connect)
S3method(pin_fetch,pins_board_folder)
S3method(pin_fetch,pins_board_kaggle_competition)
S3method(pin_fetch,pins_board_kaggle_dataset)
S3method(pin_fetch,pins_board_ms365)
S3method(pin_fetch,pins_board_rsconnect)
S3method(pin_fetch,pins_board_s3)
S3method(pin_fetch,pins_board_url)
S3method(pin_list,pins_board_azure)
S3method(pin_list,pins_board_connect)
S3method(pin_list,pins_board_folder)
S3method(pin_list,pins_board_kaggle_competition)
S3method(pin_list,pins_board_kaggle_dataset)
S3method(pin_list,pins_board_local)
S3method(pin_list,pins_board_ms365)
S3method(pin_list,pins_board_rsconnect)
S3method(pin_list,pins_board_s3)
S3method(pin_list,pins_board_url)
S3method(pin_load,default)
S3method(pin_load,files)
S3method(pin_load,package)
S3method(pin_load,table)
S3method(pin_meta,pins_board_azure)
S3method(pin_meta,pins_board_connect)
S3method(pin_meta,pins_board_folder)
S3method(pin_meta,pins_board_kaggle_competition)
S3method(pin_meta,pins_board_kaggle_dataset)
S3method(pin_meta,pins_board_ms365)
S3method(pin_meta,pins_board_rsconnect)
S3method(pin_meta,pins_board_s3)
S3method(pin_meta,pins_board_url)
S3method(pin_search,pins_board)
S3method(pin_search,pins_board_connect)
S3method(pin_search,pins_board_kaggle_competition)
S3method(pin_search,pins_board_kaggle_dataset)
S3method(pin_search,pins_board_rsconnect)
S3method(pin_store,pins_board_azure)
S3method(pin_store,pins_board_connect)
S3method(pin_store,pins_board_folder)
S3method(pin_store,pins_board_kaggle_competition)
S3method(pin_store,pins_board_kaggle_dataset)
S3method(pin_store,pins_board_ms365)
S3method(pin_store,pins_board_rsconnect)
S3method(pin_store,pins_board_s3)
S3method(pin_store,pins_board_url)
S3method(pin_version_delete,pins_board)
S3method(pin_version_delete,pins_board_azure)
S3method(pin_version_delete,pins_board_connect)
S3method(pin_version_delete,pins_board_folder)
S3method(pin_version_delete,pins_board_ms365)
S3method(pin_version_delete,pins_board_rsconnect)
S3method(pin_version_delete,pins_board_s3)
S3method(pin_version_delete,pins_board_url)
S3method(pin_versions,pins_board)
S3method(pin_versions,pins_board_azure)
S3method(pin_versions,pins_board_connect)
S3method(pin_versions,pins_board_folder)
S3method(pin_versions,pins_board_kaggle_dataset)
S3method(pin_versions,pins_board_ms365)
S3method(pin_versions,pins_board_rsconnect)
S3method(pin_versions,pins_board_s3)
S3method(pin_versions,pins_board_url)
S3method(print,pin_info)
Expand All @@ -129,8 +129,8 @@ S3method(print,pins_hidden)
S3method(print,pins_meta)
S3method(required_pkgs,pins_board)
S3method(required_pkgs,pins_board_azure)
S3method(required_pkgs,pins_board_connect)
S3method(required_pkgs,pins_board_ms365)
S3method(required_pkgs,pins_board_rsconnect)
S3method(required_pkgs,pins_board_s3)
S3method(str,pins_hidden)
S3method(write_board_manifest_yaml,default)
Expand All @@ -143,6 +143,7 @@ export("%>%")
export(board_azure)
export(board_browse)
export(board_cache_path)
export(board_connect)
export(board_default)
export(board_deparse)
export(board_deregister)
Expand Down
3 changes: 3 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

## Breaking changes

* Change the function `board_rsconnect()` to `board_connect()`, following
RStudio's rebranding to Posit (#689).

* Changed `type = "csv"` to use R's default value for `stringsAsFactors` i.e.
`FALSE` (#664).

Expand Down
2 changes: 1 addition & 1 deletion R/board.R
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ board_cache_path <- function(name) {
#' @keywords internal
#' @examples
#' \dontrun{
#' board <- board_rsconnect()
#' board <- board_connect()
#' # Generate code to access this board from elsewhere
#' board_deparse(board)
#' }
Expand Down
Loading

0 comments on commit cf70d5c

Please sign in to comment.