Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean sourcepos records when they come from metadata. #111

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

dmurdoch
Copy link
Contributor

@dmurdoch dmurdoch commented Dec 8, 2023

NB: the sourcepos records refer to the intermediate .md file, not the .Rmd file. I'll be updating the RmdConcord package to correct these based on the knitr concordance record.

I looked into the possibility of keeping the metadata sourcepos records, but it's just too much trouble.

NB:  the sourcepos records refer to the intermediate .md file, not the .Rmd file.
@yihui yihui linked an issue Dec 8, 2023 that may be closed by this pull request
Copy link
Member

@yihui yihui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thanks!

@yihui yihui merged commit 384c454 into rstudio:master Dec 8, 2023
1 check passed
@dmurdoch
Copy link
Contributor Author

Just a note to say that the RmdConcord package v 0.3 now supports html_format documents (using the RmdConcord::html_formatC name), and has been accepted on CRAN. It requires markdown version 1.12.1 or higher (i.e. this PR) to do anything; it'll just give a warning if you try to use it with an older version. This means that check warnings from tidy_validate can be connected back to the source line in the Rmd file.

@yihui
Copy link
Member

yihui commented Dec 11, 2023

Thanks for the heads up! The next version of markdown may be released in January next year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: support sourcepos = TRUE
2 participants