don't wrap meta variables include-before/after inside <div>; just use…

… whatever values user provides
rstudio · Nov 30, 2023 · 8ee6756 · 8ee6756
1 parent d4fe00c
commit 8ee6756
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 6 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -1,7 +1,7 @@
 Package: markdown
 Type: Package
 Title: Render Markdown with 'commonmark'
-Version: 1.11.1
+Version: 1.11.2
 Authors@R: c(
    person("Yihui", "Xie", role = c("aut", "cre"), email = "[email protected]", comment = c(ORCID = "0000-0003-0645-5666")),
    person("JJ", "Allaire", role = "aut"),

diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,6 @@
 # CHANGES IN markdown VERSION 1.12
 
+- The default HTML template no longer wraps meta variables `include-before` and `include-after` inside `<div></div>`, because their values may contain incomplete HTML tags, e.g., `include-before = '<div>'` and `include-after = '</div>'`.
 
 # CHANGES IN markdown VERSION 1.11
 

diff --git a/inst/resources/markdown.html b/inst/resources/markdown.html
@@ -12,9 +12,7 @@
 </head>
 
 <body>
-<div class="include-before">
 $include-before$
-</div>
 
 <div class="frontmatter">
 <div class="title"><h1>$title$</h1></div>
@@ -26,9 +24,7 @@
 $body$
 </div>
 
-<div class="include-after">
 $include-after$
-</div>
 
 $js$
 </body>

diff --git a/tests/tests.Rout.save b/tests/tests.Rout.save
@@ -1,5 +1,5 @@
 
-R version 4.3.1 (2023-06-16) -- "Beagle Scouts"
+R version 4.3.2 (2023-10-31) -- "Eye Holes"
 Copyright (C) 2023 The R Foundation for Statistical Computing
 Platform: aarch64-apple-darwin20 (64-bit)