Don't dynamically link to libuv on macOS #376
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #374
The linker on macOS always prefers to dynamically link, so if you have both shared and static versions of a library, the shared will be picked. To force static linking yet still use system libuv if found, this PR copies
libuv.a
to a different directory and renames it tolibuv_static.a
, and that's what gets passed in thePKG_LIBS
.Before, you see it linking to the dylib:
After, there is no link to the dylib:
To confirm the fallback behavior, I deleted libuv.a, so pkg-config will still find libuv, but the static library isn't there. It correctly switches to the bundled build: