Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of overflow and width in fill container/item css #401

Merged
merged 4 commits into from
Sep 7, 2023
Merged

Remove use of overflow and width in fill container/item css #401

merged 4 commits into from
Sep 7, 2023

Conversation

cpsievert
Copy link
Collaborator

@cpsievert cpsievert commented Sep 5, 2023 •
edited
Loading

Closes #399
Closes #400

Follow up items

  • Require dev version in htmlwidgets and get rid of it's use of overflow-hidden
  • Require dev version in bslib when implementing box-shadow styles

@cpsievert cpsievert requested a review from gadenbuie September 5, 2023 22:16
@cpsievert cpsievert mentioned this pull request Sep 5, 2023
Merged
1 task
gadenbuie
gadenbuie approved these changes Sep 7, 2023
View reviewed changes
Copy link
Member

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cpsievert cpsievert merged commit 6bd56cd into main Sep 7, 2023
@cpsievert cpsievert deleted the feat/html-fill-overflow-2 branch September 7, 2023 14:45
@cpsievert cpsievert mentioned this pull request Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadenbuie gadenbuie gadenbuie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fill containers/items can spill out into their parent's margin Fill items clip child content
2 participants
@cpsievert @gadenbuie