-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .noWS argument to withTags() #245
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schloerke
reviewed
May 14, 2021
schloerke
approved these changes
May 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM given suggestion
Can you add some unit tests? |
wch
reviewed
May 14, 2021
Co-authored-by: Winston Chang <[email protected]>
Co-authored-by: Barret Schloerke <[email protected]>
I think the failing checks were just unlucky; they didn't make it past the setup step on macOS. I can't re-run the jobs but I suspect the checks would pass if someone were to do that for me. 😇 |
Checks pass. @wch , Ok to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #243
Offered as a possible solution to #243. Rather than adding a global option to control
.noWS
, this suggestion adds.noWS
towithTags()
, using the sketch from @wch in #243 (comment).If
.noWS
isn't set,withTags()
works as before.But setting
.noWS
onwithTags()
sets the whitespace option for all tags in thewithTags()
call.You can still set
.noWS
on individual tags to override the whitespace option for an individual tag.If this seems like a reasonable approach, I can follow up with additional tests.