Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doRenderTags() now handles a top-level tagFunction() #204

Merged
merged 3 commits into from
Mar 22, 2021

Conversation

cpsievert
Copy link
Collaborator

Closes #203

@cpsievert cpsievert merged commit 10d6287 into master Mar 22, 2021
@cpsievert cpsievert deleted the doRenderTagFunction branch March 22, 2021 14:32
NEWS.md Show resolved Hide resolved
@wch
Copy link
Collaborator

wch commented Mar 22, 2021

I'm a bit concerned that if tag functions are passed directly to doRenderTags(), information like html dependencies will be lost. In my reading of the code is that, until this change, doRenderTags() has been meant to be used with plain tag-like objects which have already had that processing done (usually by renderTags()). After this change, it's unclear to me exactly what doRenderTags() is supposed to accept -- it can now accept tagFunctions, but in so doing it will lose html dependency info.

When does this change actually makes a difference in behavior, and does it make more sense to fix those cases?

@cpsievert
Copy link
Collaborator Author

Good point.

The motivation for this change is to make shiny:::processDeps(buildTabItem(...)) (i.e., insertTab() et. al) work in rstudio/shiny#3315.

I'll revert this change and add the special case in processDeps() instead

cpsievert added a commit that referenced this pull request Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doRenderTags() fails with a top-level tagFunction()
2 participants