Allow to set the lang attribute, will close #82 #185
Conversation
|
Nice, thanks! We'd also appreciate a NEWS item and a unit test. |
|
It seems to me that the We currently have a PR for this in Shiny, where we're adding a @yihui, @cderv, What cases do you have in mind where |
|
Test and NEWS bullet added ✅ |
I don't have a specific case in mind other than exporting some HTML to a file - it is just that I recently understand than setting I am not sure anyone will provide Example of providing `tags$html(lang = "fr", ...)`library(htmltools)
temp_html <- tempfile(fileext = ".html")
html <- tags$html(
lang="fr",
tags$head(
tags$style("h1{color:red;}")
),
tags$body(
tags$h1("title", id = "title1")
)
)
save_html(html, temp_html)
xfun::file_string(temp_html)
#> <!DOCTYPE html>
#> <html>
#> <head>
#> <meta charset="utf-8"/>
#> <style>body{background-color:white;}</style>
#>
#> <style>h1{color:red;}</style>
#> </head>
#> <html lang="fr">
#> <body>
#> <h1 id="title1">title</h1>
#> </body>
#> </html>
#> </html>
unlink(temp_html)Created on 2020-10-05 by the reprex package (v0.3.0.9001) If we don't want to have specific attributes as function parameters, we could make it more generic and the function could take a list of save_html(html, file = "test.html", html.attr = list(lang="fr")) |
No description provided.