Add parseCssColors() function #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
reviewed
Feb 18, 2020
cpsievert
reviewed
Feb 18, 2020
|
Didn't realize the HSL-to-RGB conversion was in the spec: https://www.w3.org/TR/css-color-3/#hsl-color |
cpsievert
reviewed
Feb 18, 2020
cpsievert
reviewed
Feb 18, 2020
cpsievert
reviewed
Feb 18, 2020
cpsievert
reviewed
Feb 18, 2020
cpsievert
reviewed
Feb 18, 2020
cpsievert
reviewed
Feb 18, 2020
Co-Authored-By: Carson Sievert <[email protected]>
cpsievert
reviewed
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parseCssColorstakes CSS colors as strings, removes insignificant whitespace, decodes them to RGB (includinghsl()), and returns strings in#RRGGBB(AA)form. (Note that IE11 doesn't support #RRGGBBAA; the point of this isn't to send the return values to the browser, but for them to be used in R.)We've needed this in a few packages already (gt, shiny, bootstraplib); seems like a good time to robustify and centralize this logic.
Testing notes
This feature has comprehensive unit tests.