Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add valid css units #134

Merged
merged 3 commits into from
Aug 26, 2019
Merged

Add valid css units #134

merged 3 commits into from
Aug 26, 2019

Conversation

atusy
Copy link
Contributor

@atusy atusy commented Aug 1, 2019

This PR adds valid css units such as ch and rem.

I'd also want to support calc().
However, regex for fully validating it will be quite complex.
What about just add calc(.*) ?

@jcheng5
Copy link
Member

jcheng5 commented Aug 1, 2019

calc(.*) is totally fine IMHO, or I guess ^calc\\(.*\\)$

Thanks for the contribution! Have you ever filed a contributor agreement with RStudio before? If not, we'll need that on file before we can merge. Sorry for the inconvenience.

Thanks again!

@atusy
Copy link
Contributor Author

atusy commented Aug 1, 2019

Thanks. I added calc\\(.*\\)

About the contributor agreement, yes, I have when I contributed to bookdown.

@wch wch merged commit 775d7c6 into rstudio:master Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants