More efficient rownum_translation()
#1925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome ! Thank you very much! Feel free to send more of these improvements if you identify other ones! The test suite is pretty robust to prevent regression they end up piling up and rendering time is much faster than it was just 1 year ago |
This comment has been minimized.
This comment has been minimized.
|
Thanks! I've updated the description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the performance of
rownum_translation(), replacing an inefficient loop withmatch(). Closes #1924.Related GitHub Issues and PRs
Checklist
testthatunit tests totests/testthatfor any new functionality.