Update documentation to reflect PR in rmarkdown to exclude renv directory #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
rmarkdown PR has been merged - dev version 2.6.4 |
|
Could you give us a PR with just the diffs for website.Rmd? Also, there appear to be a ton of changes to website.Rmd that are just line-wrapping. If we could get rid of those as well it's easier to evaluate and merge the PR (otherwise we sort of need to look at every line to make sure the change is okay). Thanks! |
|
Oh, my bad. Looks like the project had the option to write canonical rmarkdown on save and I didn't notice because I had soft line wrapping active. Will fix and resubmit. Should the PR also include the knitted html versions of the Rmd files or just Rmd? |
|
Just Rmd is fine.
…On Tue, Dec 22, 2020 at 12:49 PM Jannik Buhr ***@***.***> wrote:
Oh, my bad. Looks like the project had the option to write canonical
rmarkdown on save and I didn't notice because I had soft line wrapping
active. Will fix and resubmit. Should the PR also include the knitted html
versions of the Rmd files or just Rmd?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#255 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAZPR3YBYG3UMZCNRNMUZLSWDL3BANCNFSM4VFWZN4Q>
.
|
|
Oh, no, this didn't do it, one second. |
|
Now it is only those 2 lines that changed :) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… in building the site.
The relevant PR I created for
rmarkdownis here rstudio/rmarkdown#1996This will exclude the renv directory so that building the site does not copy it to the publish directory.
You might want to wait with approving this PR until the change is in the
rmarkdownversion used by distill.