fix(shiny-preset): Fix page dashboard class for page_sidebar/navbar #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the
.bslib-page-dashboardclass in two cases:page_sidebar(class = "bslib-page-dashboard")adds the class to the main content area of the global sidebar, same forlayout_sidebar(class = "bslib-page-dashboard"). We now set the--_main-bgprivate CSS variable in these cases, rather than just settingbackground-color, since the latter is set via a rule with higher specificity.page_navbar(nav_panel(class = "bslib-page-dashboard"))now works as intended when a global sidebar is used. This requires a:has()selector to set the background color of the main tab content area, rather than just the main area of the nav panel (there's padding added by the outer layout sidebar that the user can't control).