Code

Add popover() API#702

Code

Merged

cpsievert merged 43 commits intomainrstudio/bslib:mainfrom popoversrstudio/bslib:popoversCopy head branch name to clipboardJul 26, 2023

+1,636-228

Commits

Commits on Jul 20, 2023

• First stab at popover()

  cpsievert

  committed
  a3c98e9

  Copy full SHA for a3c98e9

• devtools::document() (GitHub Actions)

  cpsievert

  committed
  d5a7b92

  Copy full SHA for d5a7b92

• yarn build (GitHub Actions)

  cpsievert

  committed
  deab36d

  Copy full SHA for deab36d

• Resave distributed files (GitHub Action)

  cpsievert

  committed
  fe48eb7

  Copy full SHA for fe48eb7

• Fix tooltip() options

  cpsievert

  committed
  02d42d4

  Copy full SHA for 02d42d4

• Fix careful updating logic; sync-up tooltip/popover feature-set (i.e., avoid duplication of tooltip contents & hide popover when trigger is no longer visible)

  cpsievert

  committed
  ca9470a

  Copy full SHA for ca9470a

• Better naming

  cpsievert

  committed
  fc50570

  Copy full SHA for fc50570

• Add a ShinyResizeObserver (for better resizing of output bindings that appear in tooltip/popover

  cpsievert

  committed
  05c1b03

  Copy full SHA for 05c1b03

• yarn build (GitHub Actions)

  cpsievert

  committed
  9283c28

  Copy full SHA for 9283c28

• Rd doc improvementsl update _pkgdown.yml

  cpsievert

  committed
  d5356c7

  Copy full SHA for d5356c7

• devtools::document() (GitHub Actions)

  cpsievert

  committed
  53973ec

  Copy full SHA for 53973ec

• Resave data (GitHub Action)

  cpsievert

  committed
  0a408cb

  Copy full SHA for 0a408cb

• Rd doc improvements; update _pkgdown.yml

  cpsievert

  committed
  82cc626

  Copy full SHA for 82cc626

• Move popover-header css to js

  cpsievert

  committed
  045e2a1

  Copy full SHA for 045e2a1

• devtools::document() (GitHub Actions)

  cpsievert

  committed
  d24fc93

  Copy full SHA for d24fc93

• yarn build (GitHub Actions)

  cpsievert

  committed
  b5d5a09

  Copy full SHA for b5d5a09

• Resave distributed files (GitHub Action)

  cpsievert

  committed
  d34a921

  Copy full SHA for d34a921

• Be more careful about the possibility of content/header not existing (which will be the case when the popover/tooltip is shown

  cpsievert

  committed
  7229245

  Copy full SHA for 7229245

• yarn build (GitHub Actions)

  cpsievert

  committed
  7741c73

  Copy full SHA for 7741c73

Commits on Jul 21, 2023

• Better handling of NULL options

  cpsievert

  committed
  e0b278d

  Copy full SHA for e0b278d

• Better focus management

  cpsievert

  committed
  30dd252

  Copy full SHA for 30dd252

• Revert addition of getFirstFocusableChild helper (since we no longer need it)

  cpsievert

  committed
  8e31525

  Copy full SHA for 8e31525

• Get rid of additional content wrapper in tooltip()

  cpsievert

  committed
  b3d4874

  Copy full SHA for b3d4874

• Always include a close button, and put it in the body if no title is provided

  cpsievert

  committed
  961fffa

  Copy full SHA for 961fffa

• Update themer demo to use tooltip() & popover()

  cpsievert

  committed
  e0af44a

  Copy full SHA for e0af44a

• devtools::document() (GitHub Actions)

  cpsievert

  committed
  dc54ca6

  Copy full SHA for dc54ca6

• yarn build (GitHub Actions)

  cpsievert

  committed
  760a607

  Copy full SHA for 760a607

Commits on Jul 24, 2023

• Fixes for update_popover(). Also, simplify logic and improve styling surrounding btn-close

  cpsievert

  committed
  6168a2c

  Copy full SHA for 6168a2c

• yarn build (GitHub Actions)

  cpsievert

  committed
  7ab9dd1

  Copy full SHA for 7ab9dd1

• Resave data (GitHub Action)

  cpsievert

  committed
  87dee80

  Copy full SHA for 87dee80

Commits on Jul 25, 2023

• Close button should have type='button'

  cpsievert

  committed
  d839235

  Copy full SHA for d839235

• Code review

  cpsievert

  committed
  bbeca7c

  Copy full SHA for bbeca7c

• devtools::document() (GitHub Actions)

  cpsievert

  committed
  5716ee6

  Copy full SHA for 5716ee6

• yarn build (GitHub Actions)

  cpsievert

  committed
  300a74c

  Copy full SHA for 300a74c

Commits on Jul 26, 2023

• Remove file committed by mistake

  cpsievert

  committed
  f176b4f

  Copy full SHA for f176b4f

• Better support for hyperlinks/anchors

  cpsievert

  committed
  89f99f2

  Copy full SHA for 89f99f2

• Update aria-pressed in shown/hidden events (important when the show/hide is deriving from Bootstrap's event listeners

  cpsievert

  committed
  1743e69

  Copy full SHA for 1743e69

• Simplify/improve close button styles

  cpsievert

  committed
  83d5e85

  Copy full SHA for 83d5e85

• Merge branch 'main' into popovers

  cpsievert

  authored
  a007e29

  Copy full SHA for a007e29

• devtools::document() (GitHub Actions)

  cpsievert

  committed
  cefd8aa

  Copy full SHA for cefd8aa

• yarn build (GitHub Actions)

  cpsievert

  committed
  89dac5c

  Copy full SHA for 89dac5c

• Update NEWS

  cpsievert

  committed
  2ad7b36

  Copy full SHA for 2ad7b36

• Tweak NEWS wording

  cpsievert

  committed
  865b844

  Copy full SHA for 865b844