Add page_sidebar()
#588
Add page_sidebar()
#588
Conversation
inst/components/fill.scss
Outdated
| .bslib-page-title { | ||
| background-color: $bslib-page-title-bg; | ||
| color: $bslib-page-title-color; | ||
| font-size: $h4-font-size; | ||
| font-weight: 300; | ||
| padding: $spacer * 0.5; | ||
| padding-left: $bslib-sidebar-padding; | ||
| margin-bottom: 0; |
There was a problem hiding this comment.
Overall this is great! Given that both Bootstrap provides three navbar color schemes and that Bootswatch highlights these in their theme previews, I think we might want to think about leaving some room for building on those classes in the future.
Maybe we could take inspiration from quarto, who IIUC add some sass variables around navbar color and hook off of that. Maybe we'd hook into a sass variable that could be set easily via bs_theme()?
I think we're on a reasonable path that would allow for this kind of expansion, but I also think we can reasonably expect users to ask for something like this soon.
There was a problem hiding this comment.
Good point, Quarto actually got the $navbar-bg from bslib :)
|
I'm going to go ahead and merge this since it's sort of blocking to the website updates, but feel free to keep commenting on things to follow up on . |
Partially addresses #569
TODO
page_sidebar()into306shinycoreci#184 provides some coverage