Fixes for bs5 sketchy #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
force-pushed
the
bs5-sketchy
branch
3 times, most recently
from
3b45c9a to
a6d38c5
Compare
cpsievert
commented
Oct 25, 2021
| @@ -159,8 +159,8 @@ select.form-control { | |||
| border-radius: $border-radius-lg-sketchy !important; | |||
| } | |||
|
|
|||
| [type="checkbox"] { | |||
| position: relative !important; | |||
| #{$shiny-check} input, #{$shiny-check-inline} input, [type="checkbox"] { | |||
There was a problem hiding this comment.
For reference
bslib/inst/lib/bs5/scss/_forms.scss
Lines 1 to 7 in fff5b6b
cpsievert
commented
Oct 25, 2021
| [type="radio"] { | ||
| position: relative !important; | ||
| #{$shiny-radio} input, #{$shiny-radio-inline} input, [type="radio"] { | ||
| position: relative; |
There was a problem hiding this comment.
For context, the !important was added by me (for BS4) to fix a similar issue (with Bootstrap's form CSS taking higher priority than these rules). However, now (with BS5) some of the other properties here (most importantly, width) are also overridden by Bootstrap's form CSS. Instead of adding !important everywhere, we can leverage the shiny form selector variables that I've already added to BS5 source for BS3 compatibility.
cpsievert
force-pushed
the
bs5-sketchy
branch
from
39ca081 to
c99487f
Compare
|
(Reviewed with @schloerke) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #382