You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
htmltools::bindFillRole() has recently (rstudio/htmltools#399) gone all the way with removing overflow: auto from fill items/containers (and instead now uses min-height: 0 where appropriate). Those changes will also come with the removal of width: 100% (rstudio/htmltools#400).
This, at the very least, has a couple consequences for our current card()/value_box() css.
When it come to cards, I think we should add back .bslib-card{ overflow: auto; } and allow users to opt-out if they want to (perhaps with card(scroll = FALSE)?). Also, we if provide a way to opt-out there, we should probably do the same for layout_sidebar(), card_body(), etc?
When it comes to value_box(), I'm not yet sure exactly what CSS we'll want, but it seems like we can get away with just adding the width: 100% back on the showcase container. For an example of what has changed, run runApp("inst/examples/value_box") and notice how the showcase in the 2nd value box goes beyond the value_box() container
The text was updated successfully, but these errors were encountered:
htmltools::bindFillRole()
has recently (rstudio/htmltools#399) gone all the way with removingoverflow: auto
from fill items/containers (and instead now usesmin-height: 0
where appropriate). Those changes will also come with the removal ofwidth: 100%
(rstudio/htmltools#400).This, at the very least, has a couple consequences for our current
card()
/value_box()
css.When it come to cards, I think we should add back
.bslib-card{ overflow: auto; }
and allow users to opt-out if they want to (perhaps withcard(scroll = FALSE)
?). Also, we if provide a way to opt-out there, we should probably do the same forlayout_sidebar()
,card_body()
, etc?When it comes to
value_box()
, I'm not yet sure exactly what CSS we'll want, but it seems like we can get away with just adding thewidth: 100%
back on the showcase container. For an example of what has changed, runrunApp("inst/examples/value_box")
and notice how the showcase in the 2nd value box goes beyond thevalue_box()
containerThe text was updated successfully, but these errors were encountered: