Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle fallout from removal of overflow:auto on fill items/containers #793

Closed
cpsievert opened this issue Sep 11, 2023 · 1 comment · Fixed by #794
Closed

Handle fallout from removal of overflow:auto on fill items/containers #793

cpsievert opened this issue Sep 11, 2023 · 1 comment · Fixed by #794

Comments

@cpsievert
Copy link
Collaborator

cpsievert commented Sep 11, 2023

htmltools::bindFillRole() has recently (rstudio/htmltools#399) gone all the way with removing overflow: auto from fill items/containers (and instead now uses min-height: 0 where appropriate). Those changes will also come with the removal of width: 100% (rstudio/htmltools#400).

This, at the very least, has a couple consequences for our current card()/value_box() css.

When it come to cards, I think we should add back .bslib-card{ overflow: auto; } and allow users to opt-out if they want to (perhaps with card(scroll = FALSE)?). Also, we if provide a way to opt-out there, we should probably do the same for layout_sidebar(), card_body(), etc?

When it comes to value_box(), I'm not yet sure exactly what CSS we'll want, but it seems like we can get away with just adding the width: 100% back on the showcase container. For an example of what has changed, run runApp("inst/examples/value_box") and notice how the showcase in the 2nd value box goes beyond the value_box() container

Copy link

This issue has been automatically locked. If you have found a related problem, please open a new issue (with a reproducible example or feature request) and link to this issue.
🙋 Need help? Connect with us on Discord or Posit Community.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant