Skip to content

Commit

Permalink
Revert "dataTableOutput()'s width and height now default to NULL (#1026
Browse files Browse the repository at this point in the history
…)"

This reverts commit e02783c.
  • Loading branch information
cpsievert committed Oct 25, 2022
1 parent e02783c commit 7926134
Show file tree
Hide file tree
Showing 5 changed files with 4 additions and 20 deletions.
2 changes: 0 additions & 2 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# CHANGES IN DT VERSION 0.27

- `dataTableOutput()`'s `height` and `width` now defaults to `NULL`, allowing it have more flexible default sizing behavior, which will be primarily useful in combination with `{bslib}`'s new `card()` API (thanks, @cpsievert, #1026).

# CHANGES IN DT VERSION 0.26

- Upgraded DataTables to v1.12.1.
Expand Down
2 changes: 1 addition & 1 deletion R/shiny.R
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
#' }
#' )
#' }
dataTableOutput = function(outputId, width = NULL, height = NULL) {
dataTableOutput = function(outputId, width = '100%', height = 'auto') {
htmltools::attachDependencies(
htmlwidgets::shinyWidgetOutput(
outputId, 'datatables', width, height, package = 'DT'
Expand Down
11 changes: 0 additions & 11 deletions inst/htmlwidgets/css/datatables.css

This file was deleted.

5 changes: 1 addition & 4 deletions inst/htmlwidgets/datatables.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,4 @@ dependencies:
- name: datatables-css
version: 0.0.0
src: "htmlwidgets/css"
stylesheet: [
datatables.css,
datatables-crosstalk.css
]
stylesheet: datatables-crosstalk.css
4 changes: 2 additions & 2 deletions man/dataTableOutput.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 7926134

Please sign in to comment.