Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read files with utf-8 encoding #187

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Read files with utf-8 encoding #187

wants to merge 1 commit into from

Conversation

Paxa
Copy link

@Paxa Paxa commented Dec 18, 2014

If css file contain some non ascii characters it will fail with exception

For example it fail on https://github.com/dbushell/Pikaday/blob/master/css/pikaday.css (© is not ascii)

This commit read all files in utf-8 encoding

@j15e
Copy link
Collaborator

j15e commented Jan 16, 2015

What if the file is not utf-8 encoded? I think it would be better to read the file binary then detect encoding as done in sprocket for exemple : https://github.com/sstephenson/sprockets/blob/faceba518a866aee4c454775112a578e2f3ff166/lib/sprockets/mime.rb#L79-L102

@Paxa
Copy link
Author

Paxa commented Sep 2, 2015

Anyone wanna implement encoding detection or we close pull request?

@j15e
Copy link
Collaborator

j15e commented Sep 2, 2015

In case you missed it, see #197

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants