This repository has been archived by the owner on Nov 30, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 103
Reduce memory usage by using frozen string literals #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was running memory_profiler on a spec with a large number of examples (950), and it surfaced several places in rspec-support that aren't using frozen strings. Originally, it was `::` in lib/rspec/support/recursive_const_methods.rb that caught my attention, but I figure it can be enabled everywhere. I did not enable it for specs, because I figure that wouldn't have as much impact since it would only affect rspec-support's specs.
Here's the relevent sections from memory_profiler for running a spec in our suite. Before:
After (by running
A more human readable summary/interpretation:
|
JonRowe
approved these changes
Oct 6, 2023
JonRowe
added a commit
that referenced
this pull request
Feb 4, 2024
Reduce memory usage by using frozen string literals
JonRowe
added a commit
that referenced
this pull request
Feb 4, 2024
Released in 3.12.2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running memory_profiler on a spec with a large number of examples (950), and it surfaced several places in rspec-support that aren't using frozen strings.
Originally, it was
::
inlib/rspec/support/recursive_const_methods.rb
that caught my attention, but I figure it can be enabled everywhere.I did not enable it for specs, because I figure that wouldn't have as much impact since it would only affect rspec-support's specs.
I'll include some memory_profile details in the comments.