Fix support for Rails 4.2 #2479
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonRowe
reviewed
Mar 10, 2021
lib/rspec/rails/fixture_support.rb
Outdated
| @@ -13,7 +13,11 @@ module FixtureSupport | |||
| # Monkey patched to avoid collisions with 'let(:name)' in Rails 6.1 and after | |||
| # and let(:method_name) before Rails 6.1. | |||
| def run_in_transaction? | |||
| use_transactional_tests && !self.class.uses_transaction?(self) | |||
| if ::Rails::VERSION::STRING > '5' | |||
There was a problem hiding this comment.
Generally, we define conditional methods rather than use run time checks, and this should probably check for the existence of use_transactional_tests directly rather than a version, although if you leave it on a version it should be >= 5
tagliala
force-pushed
the
4-1-maintenance
branch
from
b044d95 to
c100cf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 4.2 does not have
use_transactional_testsdefinedFix #2477