[WiP] Update of request specs generator due to change in rails 6.1 controller default behaviour.

[panSarin]

Since rails 6.1.1 changed default behaviour of CRUD response for invalid
attributes - to respond with 422 status, we have to update our scaffold
for generating specs for Create and Update with invalid attributes.

I updated both generators to check if controller responds with status
422 instead of 200.

Also, I didn't find any tests about those generators, so I couldn't update them - if there are some, please let me know so I can update them.

Linked issue: #2463

[pirj]

We aim to support Rails 5.0, 5.1, 5.2 and 6.0 as well (actually, even 4.2 should probably work). Will the generator work in those versions correctly?

Do you mind adding a test that would run this generated test?
I'm mostly interested in reproducing the failure you observe in 6.1.1, that would fail without your fix.

[panSarin]

Oh that is true. I should think about backwards compatibilty too. Let me figure out how to check version of rails that we generating tests for and update that.

Also any hint if there are such tests that i can base on to add test to that change?

[pirj]

rspec-rails/example_app_generator/generate_stuff.rb

Line 97 in a785198

generate('scaffold widget name:string category:string instock:boolean foo_id:integer bar_id:integer --force')

should generate a controller and its specs. Those specs are run afterwards. It is worth checking what exactly is generated, and why generated request specs won't fail on 6.1.1.

[panSarin]

Thanks for the hints! I am on it.

[panSarin]

@pirj so I tried to test it by example app, and I encounter problems with generating example app for rails 6.1
I found there is opened #2398 PR for that. Is it planned to be merged soon or I should create that PR for that branch?

Also to make that test fail there is one more step to reproduce: we have to add some model validation and fill invalid attributes, because by default they are skipped and there is no validation, so we will never go into "bad path".

But still I think that is a case to fix - pleace correct me if I am wrong.

[pirj]

Ouch. Sorry, I forgot to point out that we have a branch for 6.1 fixes, rails-6-1-dev.
We've just one fix left to merge, #2461, and hopefully, it is ready.
Your fix can be part of that branch. Please let me know if you can change the base branch:

or I can do it for you.

and fill invalid attributes

I would suggest gsub'ing required files as we do here

rspec-rails/example_app_generator/generate_stuff.rb

Line 148 in a785198

gsub_file 'spec/spec_helper.rb',

[pirj]

That looks better! 👍
Just need a test to prove it fixes it for 6.1.1 and doesn't break for previous ones.

[panSarin]

Test to prove it fixes it for 6.1.1 - what you mean by "test" there, some unit test, or more like recorded video where i generate app for 5.x and 6.0 versions and it generates old version ( which works ) and another for 6.1.1 where it works with new version ?

I am not familiar with testing tools that generate tests ;]

[pirj]

rspec-rails/example_app_generator/generate_stuff.rb should generate a controller and its specs. Those specs are run afterwards. I would suggest gsub'ing those generated files

to include necessary validation for 422 to be triggered.
That's it!

[panSarin]

Due to mess i had in commits and branches, i opened new clear PR so I am closing that and moving further conversation to #2466