Clear test mailbox from ActionMailer::Base between each example #2293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoittgt
commented
Mar 20, 2020
JonRowe
reviewed
Mar 20, 2020
| @@ -256,6 +256,31 @@ def self.application; end | |||
| expect(group.mailer_class).to be(a_mailer_class) | |||
| expect(group.new).to be_a(RSpec::Rails::MailerExampleGroup) | |||
| end | |||
|
|
|||
| describe 'cleans test mailbox between each example in all rspec-rails example' do | |||
| class BaseMailer < ActionMailer::Base | |||
There was a problem hiding this comment.
Can this be an anonymous class in a let?
There was a problem hiding this comment.
Could you explain you prefer?
Done with 368484b
JonRowe
requested changes
Mar 20, 2020
|
Does this fix the problem you're experiencing @cunknown? |
|
JRuby failures are unrelated, fixed on JRuby |
It has been tested against the repo provided + the test I wrote with the mailer service. |
JonRowe
approved these changes
Mar 20, 2020
|
@benoittgt Changelog? |
|
🙏 Thank you! |
pirj
reviewed
Mar 20, 2020
| @@ -18,6 +18,7 @@ Bug Fixes: | |||
| (Jonathan Rochkind, #2242) | |||
| * `rails generate generator` command now creates related spec file (Joel Azemar, #2217) | |||
| * Relax upper `capybara` version constraint to allow for Capybara 3.x (Phil Pirozhkov, #2281) | |||
| * Leans ActionMailer test mailbox after each example (Benoit Tigeot, #2293) | |||
JonRowe
added a commit
that referenced
this pull request
Mar 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We notice in #2290 that
ActionMailer::Base.deliveries mailbox is not cleaned between example.
Fix: #2290