Prevent collisions on let(:name) and let(:method_name) #2461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcgraham
reviewed
Feb 18, 2021
lib/rspec/rails/fixture_support.rb
Outdated
| # Monkey patched to avoid collisions with 'let(:name)' in Rails 6.1 and after | ||
| # and let(:method_name) before Rails 6.1. | ||
| def run_in_transaction? | ||
| use_transactional_tests && !self.class.uses_transaction?(@example) |
There was a problem hiding this comment.
Not “reviewing,” just curious - were you able to determine whether any RSpec code still sets @example to a meaningful value?
There was a problem hiding this comment.
No I didn't search this yet. But I will.
There was a problem hiding this comment.
For us this probably needs to be example or self as we don't assign @example within a test like mini test does afaik
pirj
changed the title
pirj
force-pushed
the
rails-6-1-issue-2451-dev
branch
from
c44c923 to
ee760f2
Compare
|
Rebased. Green. |
JonRowe
added a commit
that referenced
this pull request
Feb 20, 2021
Prevent collisions on let(:name) and let(:method_name)
pirj
pushed a commit
that referenced
this pull request
Feb 21, 2021
Prevent collisions on let(:name) and let(:method_name)
alexrothenberg
added a commit
to alexrothenberg/ammeter
that referenced
this pull request
Feb 24, 2021
It seems like rails 6.1 broke rspec <4.0 until it was fixed with rspec/rspec-rails#2215 then fixed differently with rspec/rspec-rails#2461 so we skip rspec 3x with rails 6.1 in CI
alexrothenberg
added a commit
to alexrothenberg/ammeter
that referenced
this pull request
Feb 24, 2021
It seems like rails 6.1 broke rspec <4.0 until it was fixed with rspec/rspec-rails#2215 then fixed differently with rspec/rspec-rails#2461 so we skip rspec 3x with rails 6.1 in CI
alexrothenberg
added a commit
to alexrothenberg/ammeter
that referenced
this pull request
Feb 24, 2021
It seems like rails 6.1 broke rspec-rails. RSpec-rails 4.0 fixed it with rspec/rspec-rails#2215 then fixed differently with rspec/rspec-rails#2461 so we skip rspec-rails >4 with rails 6.1 in CI
alexrothenberg
added a commit
to alexrothenberg/ammeter
that referenced
this pull request
Feb 24, 2021
It seems like rails 6.1 broke rspec-rails. RSpec-rails 4.0 fixed it with rspec/rspec-rails#2215 then fixed differently with rspec/rspec-rails#2461 so we skip rspec-rails >4 with rails 6.1 in CI
alexrothenberg
added a commit
to alexrothenberg/ammeter
that referenced
this pull request
Feb 24, 2021
It seems like rails 6.1 broke rspec-rails. RSpec-rails 4.0 fixed it with rspec/rspec-rails#2215 then fixed differently with rspec/rspec-rails#2461 so we skip rspec-rails >4 with rails 6.1 in CI
alexrothenberg
added a commit
to alexrothenberg/ammeter
that referenced
this pull request
Feb 24, 2021
It seems like rails 6.1 broke rspec-rails. RSpec-rails 4.0 fixed it with rspec/rspec-rails#2215 then fixed differently with rspec/rspec-rails#2461 so we skip rspec-rails >4 with rails 6.1 in CI
alexrothenberg
added a commit
to alexrothenberg/ammeter
that referenced
this pull request
Feb 24, 2021
It seems like rails 6.1 broke rspec-rails. RSpec-rails 4.0 fixed it with rspec/rspec-rails#2215 then fixed differently with rspec/rspec-rails#2461 so we skip rspec-rails >4 with rails 6.1 in CI
alexrothenberg
added a commit
to alexrothenberg/ammeter
that referenced
this pull request
Feb 24, 2021
It seems like rails 6.1 broke rspec-rails. RSpec-rails 4.0 fixed it with rspec/rspec-rails#2215 then fixed differently with rspec/rspec-rails#2461 so we skip rspec-rails >4 with rails 6.1 in CI
alexrothenberg
added a commit
to alexrothenberg/ammeter
that referenced
this pull request
Feb 24, 2021
Some of the missing combinations in the matrix: * Ruby 3 with Rails 5.2 are skipped because my tests error when trying to start rails * Rspec-rails 3 with Rails 6.1 because of a rails change rspec-rails needs rspec/rspec-rails#2215 or the more recent rspec/rspec-rails#2461
alexrothenberg
added a commit
to alexrothenberg/ammeter
that referenced
this pull request
Feb 24, 2021
Some of the missing combinations in the matrix: * Ruby 3 with Rails 5.2 are skipped because my tests error when trying to start rails * Rspec-rails 3 with Rails 6.1 because of a rails change rspec-rails needs rspec/rspec-rails#2215 or the more recent rspec/rspec-rails#2461
alexrothenberg
added a commit
to alexrothenberg/ammeter
that referenced
this pull request
Feb 24, 2021
Some of the missing combinations in the matrix: * Ruby 3 with Rails 5.2 are skipped because my tests error when trying to start rails * Rspec-rails 3 with Rails 6.1 because of a rails change rspec-rails needs rspec/rspec-rails#2215 or the more recent rspec/rspec-rails#2461
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #2451
Two commits. One to see the failures then one to see the fix. I did nothing specific, just implement the great work of @grekko and the choice from @JonRowe.