This repository has been archived by the owner on Nov 30, 2024. It is now read-only.
Ensure backtraces start at user code, not rspec-mocks code #1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onlynone
force-pushed
the
filter-backtraces
branch
from
25e8c6b
to
3b45cd4
Compare
onlynone
force-pushed
the
filter-backtraces
branch
from
3b45cd4
to
34b2961
Compare
|
HunkGenerator on 2.2 and 2.5 is flaky. |
|
Do you need some help with JRuby support? |
|
We already handle this in rspec-core and as per #1592 I don't want to add the maintenance burden of this, it would duplicate logic we have elsewhere. Additionally to our filtering we also have the ability to remove the filtering to allow finding issues within our, or any other filtered out code which this would circumvent. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will ensure all exceptions generated by rspec-mocks have the first line of their backtraces pointing to the user's code where the error happened.
Addresses #1592